Refactor lastUpdated #2314
Open
Refactor lastUpdated #2314
+63
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chartman123
added
php
Chartman123
force-pushed
the
chore/refactor-lastUpdated
branch
from
77999d8
to
1526824
Compare
Chartman123
changed the title
Chartman123
force-pushed
the
chore/refactor-lastUpdated
branch
5 times, most recently
from
f42bf8a
to
bedcc05
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
=======================================
Coverage ? 36.15%
Complexity ? 1014
=======================================
Files ? 70
Lines ? 3811
Branches ? 0
=======================================
Hits ? 1378
Misses ? 2433
Partials ? 0 |
Chartman123
force-pushed
the
chore/refactor-lastUpdated
branch
from
bedcc05
to
fbfb022
Compare
|
@susnux do you have any idea why I get an Error 500 as soon as I open the Forms app? |
Chartman123
force-pushed
the
chore/refactor-lastUpdated
branch
2 times, most recently
from
9aef8d5
to
2345d77
Compare
Chartman123
added
3. to review
Chartman123
force-pushed
the
chore/refactor-lastUpdated
branch
from
2345d77
to
8fcfb8a
Compare
This commit refactors the form creation and update logic in the `ApiController` class. It removes the unnecessary setting of the `created` and `lastUpdated` timestamps in the `Form` entity, as these values are now automatically set in the `FormMapper` class. This improves code readability and reduces redundancy. The changes also include updates to the `FormMapper` class, where the `insert` and `update` methods now automatically set the `created` and `lastUpdated` timestamps respectively. Signed-off-by: Christian Hartmann <[email protected]>
Chartman123
force-pushed
the
chore/refactor-lastUpdated
branch
from
8fcfb8a
to
465c921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the form creation and update logic in the
ApiControllerclass. It removes the unnecessary setting of thecreatedandlastUpdatedtimestamps in theFormentity, as these values are now automatically set in theFormMapperclass. This improves code readability and reduces redundancy.The changes also include updates to the
FormMapperclass, where theinsertandupdatemethods now automatically set thecreatedandlastUpdatedtimestamps respectively.