Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable binary path for Mailer/etc #43922

Closed
exi opened this issue Feb 29, 2024 · 5 comments · Fixed by #43968
Closed

Configurable binary path for Mailer/etc #43922

exi opened this issue Feb 29, 2024 · 5 comments · Fixed by #43968
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: emails
Milestone

Comments

@exi
Copy link
Contributor

exi commented Feb 29, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
I'm running nixOS where binaries are in non-standard locations. I can't use the sendmail sender because I can't give nextcloud the path to the binary or any kind of search path. It would be very helpful to make this configurable.

Describe the solution you'd like
A config option with additional paths that get searched in BinaryFinder

@exi exi added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Feb 29, 2024
@joshtrichards
Copy link
Member

Just to double-check: you should be able to use SMTP mode instead. It has no dependency on a local sendmail binary.

To your enhancement idea: I wonder if we should simply add PHP's own sendmail_path parameter value to our sendmail binary search path? This would offer an opportunity for local customization.

@joshtrichards joshtrichards changed the title BinaryFinder should support additional search paths Configurable sendmail binary path for Mailer Mar 1, 2024
@exi
Copy link
Contributor Author

exi commented Mar 1, 2024

@joshtrichards my mail setup uses local delivery without localhost-SMTP, so sendmail is my preferred solution.

Fixing BinaryFinder is the more general solution though since for example under NixOS, it't won't be able to find any of the expected binaries in those hard-coded locations seen in the existing BinaryFinder. Making this configurable would also allow NixOS to properly make nextcloud immutable and reproducible because it would allow us to pin the location of all involved binaries, as is standard in NixOS.

Using sendmail_path would be a working workaround, although not my preferred one.

@exi
Copy link
Contributor Author

exi commented Mar 1, 2024

@joshtrichards I don't quite agree with changing the title here. This problem goes beyond sendmail.

Finding avconv/ffmpeg/libreoffice/openoffice etc. for preview generation also does not work without customizable search paths.
Basically BinaryFinder does not work at all under NixOS without the ability to add additional searchPaths to search for.
None of the standard search paths hard-coded in BinaryFinder exist in NixOS.

@kesselb
Copy link
Contributor

kesselb commented Mar 2, 2024

Adding a configuration option to adjust the binary path sounds okay to me.
However, our security folks may have a different opinion.

Please don't hesitate to send a pull request.

exi added a commit to exi/nextcloud-server that referenced this issue Mar 3, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

This fixes issue nextcloud#43922
exi added a commit to exi/nextcloud-server that referenced this issue Mar 3, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

This fixes issue nextcloud#43922

Signed-off-by: exi <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 3, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 3, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
Signed-off-by: exi <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 3, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

This fixes issue nextcloud#43922

Signed-off-by: exi <[email protected]>
@exi
Copy link
Contributor Author

exi commented Mar 4, 2024

@kesselb See #43968 for the PR, I hope that works out.

exi added a commit to exi/nextcloud-server that referenced this issue Mar 4, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

This fixes issue nextcloud#43922

Signed-off-by: exi <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 4, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

This fixes issue nextcloud#43922

Signed-off-by: exi <[email protected]>
@joshtrichards joshtrichards changed the title Configurable sendmail binary path for Mailer Configurable binary path for Mailer/etc Mar 5, 2024
exi added a commit to exi/nextcloud-server that referenced this issue Mar 5, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 5, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 6, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 6, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 6, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 6, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 6, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 6, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
skjnldsv pushed a commit to exi/nextcloud-server that referenced this issue Mar 7, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 8, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Mar 8, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
icewind1991 pushed a commit to exi/nextcloud-server that referenced this issue May 3, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue May 3, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
kesselb pushed a commit to exi/nextcloud-server that referenced this issue May 5, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
icewind1991 pushed a commit to exi/nextcloud-server that referenced this issue May 13, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Sep 16, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Sep 16, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Sep 17, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Sep 17, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Sep 17, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Signed-off-by: Reno Reckling <[email protected]>
exi added a commit to exi/nextcloud-server that referenced this issue Sep 17, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Co-authored-by: Daniel <[email protected]>
Signed-off-by: Reno Reckling <[email protected]>
kesselb added a commit to exi/nextcloud-server that referenced this issue Sep 18, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Co-authored-by: Daniel <[email protected]>
Signed-off-by: Reno Reckling <[email protected]>
icewind1991 pushed a commit to exi/nextcloud-server that referenced this issue Sep 19, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Co-authored-by: Daniel <[email protected]>
Signed-off-by: Reno Reckling <[email protected]>
kesselb added a commit to exi/nextcloud-server that referenced this issue Sep 20, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Co-authored-by: Daniel <[email protected]>
Signed-off-by: Reno Reckling <[email protected]>
kesselb added a commit to exi/nextcloud-server that referenced this issue Sep 20, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Co-authored-by: Daniel <[email protected]>
Signed-off-by: Reno Reckling <[email protected]>
kesselb added a commit to exi/nextcloud-server that referenced this issue Sep 20, 2024
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue nextcloud#43922

Co-authored-by: Daniel <[email protected]>
Signed-off-by: Reno Reckling <[email protected]>
@AndyScherzinger AndyScherzinger added this to the Nextcloud 31 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: emails
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants