Unclosed file object

[RyanTerb]

Noticed with sarpy 1.3.30 that the sicd_writer is throwing a warning:

/usr/local/lib/python3.10/site-packages/sarpy/io/general/nitf.py:4168: ResourceWarning: unclosed file <_io.BufferedWriter name=

It looks like a file object is not being close properly and python is unhappy. Based on the this code, it might not be triggering the __del__ operator that closes the file object, link.

The following code removed the warning for me. I had to explicitly call flush though.

  writer = sicd.SICDWriter(
      file_object=filename,
      sicd_meta=SICDType(**sicd_data.__dict__),
      check_existence=False
  )

  writer.write(complex_image, (0, 0))
  writer.flush()
  writer._file_object.close()
  writer.close()

If I'm incorrectly writing a sicd_file or closing, please advise.

Thanks !

[Darder]

Did you not run into this problem before with earlier versions of SARPY?

[RyanTerb]

I have not.

[pressler-vsc]

@RyanTerb, thanks for writing this up. This does seem to be a bug in the NITFWriter introduced in the 1.3.30 refactor and is also an issue with the CPHDWriter. This should be addressed in #476.