-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in CSIDD Bits Per Pixel #544
Comments
I believe the consistency checker has the error. The The NITF standard is hard to follow, and the exact wording has changed between the MIL-STD-2500C and BIIF documents. However, I think they all restrict NBPP to 8, 16, 32, and 64 for integer pixel types. Here's the 2500C, which may be the most concise: |
Thanks @klucar and @bombaci-vsc; it does like there is a bug here in SarPy.
Table 2-6 doesn't really clarify, but the text above it appears consistent: Given this, I too think the bug is in the consistency checker. |
Looks like I guessed wrong! Want me to do a pull request or will this be fixed elsewhere? |
I don't believe this is being currently worked and PRs are always welcome! This is a good opportunity/reminder to get at least token |
Here you go! |
When writing a CSIDD in RGB24I data format, SarPy sets the number of bits per pixel (NBPP) to 8
sarpy/sarpy/io/product/sidd.py
Line 751 in 3354207
However, in the consistency checker, the number of bits it is looking for is 24.
sarpy/sarpy/consistency/sidd_consistency.py
Line 350 in 3354207
My thought is that the former needs to be 24 instead of 8.
The text was updated successfully, but these errors were encountered: