app support #221
Replies: 28 comments 20 replies
-
|
Added irplus. Will keep the issue updated. |
Beta Was this translation helpful? Give feedback.
-
|
This app was also added: https://play.google.com/store/apps/details?id=com.laurencedawson.reddit_sync Note: Currently, Sync Pro doesn't seem to work, only the regular sync app. Plus, I don't think someone would find a genuine public source for Pro as it's paid so, it needs to be used as It includes a patch named
So, I tried and succeeded in adding Sync for Reddit (base) from apkmirror source but the only thing fails the patching is the {
"patchName" : "change-oauth-client-id",
"options" : [ {
"key" : "client-id",
"value" : "REDDIT_CLIENT_ID"
} ]
}What are your opinions on this? |
Beta Was this translation helpful? Give feedback.
-
|
I believe this is very pertinent, the matter of the Sync |
Beta Was this translation helpful? Give feedback.
-
|
Hey @IMXEren thanks for the info. |
Beta Was this translation helpful? Give feedback.
-
|
Possible to also support RVX Reddit? |
Beta Was this translation helpful? Give feedback.
-
|
Sync hype sync hype. |
Beta Was this translation helpful? Give feedback.
-
|
Added the ability to patch reddit clients. Provide REDDIT_CLIENT_ID as a secret. See the last point in README.md. Let me know if it does/n't work. |
Beta Was this translation helpful? Give feedback.
-
|
Synced repo to ustream, testing... There are two situations happening to me:
That was the entry I had before, but then...
Looking at config.py it seems to be named "sync ", with a space? Same for the other clients. Trying to patch 'sync ' results in |
Beta Was this translation helpful? Give feedback.
-
|
Removing the extra spaces resulted in successful patch.
Never mind now it worked. Seems fine now in that aspect. Now there's just the invalid character to fix in the artifact: Which is already in this PR, when you can merge or use a different implementation ofc. Using this PR it worked perfectly for me aswell. |
Beta Was this translation helpful? Give feedback.
-
|
Only one issue left I'd say, I used |
Beta Was this translation helpful? Give feedback.
-
Haven't tested yet. Will sync and report the outcomes tomorrow. |
Beta Was this translation helpful? Give feedback.
-
|
@nikhilbadyal thanks for addressing these! Sorry if the question is unnecessary but... Is there a reason why some apps have spaces in their names in config: Namely infinity, slide and bacon...? |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for pointing out @Spacellary . |
Beta Was this translation helpful? Give feedback.
-
|
@nikhilbadyal |
Beta Was this translation helpful? Give feedback.
-
Okay, I'd say this can be a hectic task for new users. FYI, revanced/revanced-patches have moved their patch table to their official site and the patches there use the newest convention. If somebody wants to use them, they might have to go through all that editions to exclude their patches. Currently, I don't find any patch names with commas ( Does using the newer convention, can cause conflicts? I specifically propose to also allow newer patch names in envs. I don't consider anything for older convention. Also, to add, I haven't/can't test if inotia00/revanced-patches support both conventions as you can still see the older table but newer convention in patches.json.
@Spacellary, here's the PR #218. |
Beta Was this translation helpful? Give feedback.
-
No, it doesn't. The new convention is more readable. One issue I have with the naming convention is the spacing itself. Spaces are very easy to miss and can introduce errors. For example, it's easy to confuse Hey There with Hey There. @IMXEren , Your opinion ? |
Beta Was this translation helpful? Give feedback.
-
This can be a valid point but still renaming thing can't be overlooked. For example, let's say your repo very much appealed to a user. They read everything in your Lastly, even though it'll require me to do the same, I'll just use the Tasker integration with your repo or forked repos to do this part for me. I apologise if I sounded rude. |
Beta Was this translation helpful? Give feedback.
-
|
I agree on going for the new convention for all apps. It's less prone to user's errors and again they can't blame the project for being obtuse. |
Beta Was this translation helpful? Give feedback.
-
|
Closing the issue this as all the apps are supported now. |
Beta Was this translation helpful? Give feedback.
-
|
@nikhilbadyal I have changed my mind. But I'm conflicted, so inotia00's reasoning for keeping his ReadMe with the old convention is because that's the accepted by the CLI.jar, which I agree is a good reason. In that sense I prefer to use the old convention with the hifens, as I also think spaces don't belong there or in file names. For that reason, for what matters, I am a proponent for the names-with-hifens as they are. @IMXEren thoughts on inotia00's reasoning? |
Beta Was this translation helpful? Give feedback.
-
Again, Not much of a deal for me. Whatever dev chooses in the end is fine by me. And based on the current |
Beta Was this translation helpful? Give feedback.
-
|
I mean they could've come up with patch ids along with those. Agreed, breaking the scripts just for mere convenience, isn't a good idea. |
Beta Was this translation helpful? Give feedback.
-
|
We can support both. Maybe something like this. While parsing excluded patches if any patch contains - we can conclude the user is using an older convention otherwise new.
|
Beta Was this translation helpful? Give feedback.
-
|
Well then so for now the old convention is what to go for, so should I just keep teaching people using the old convention and not bother with the new weird one? |
Beta Was this translation helpful? Give feedback.
-
|
I'd like to confirm this too.
Sorry didn't notice this. Now, then it's old for the time being. |
Beta Was this translation helpful? Give feedback.
-
|
Yes , old for now. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @nikhilbadyal , sorry for disturbing again. I noticed some things for app sources in
|
Beta Was this translation helpful? Give feedback.
-
|
Inotia might remove MicroG support. Sharing an issue that might be of interest: |
Beta Was this translation helpful? Give feedback.
-
|
@nikhilbadyal @IMXEren I'd say to share your thoughts on it as well, at least all options are accounted for if it's inevitable. |
Beta Was this translation helpful? Give feedback.
-
|
Oh :( As I read the issue, I infer it's due to many sources which makes the patches incompatible. Why not simply set the target source and version (as you do ask)? It's also not that inotia00 doesn't provide his flavor of MicroG. For this repo, I'd vote to let it remain in the code for some time (1-2 months). Maybe the patch returns. Also, after the patch removal, it won't be patched. Will it? If not, can simply comment out microg in Thanks for letting us know. |
Beta Was this translation helpful? Give feedback.
-
Yeah... |
Beta Was this translation helpful? Give feedback.
-
|
We will still keep the code for patching microg. I hope it's a temporary suspension. |
Beta Was this translation helpful? Give feedback.
-
|
For the record: feat(microg): temporary suspension of support for all patches: inotia00/revanced-patches@03b9875 |
Beta Was this translation helpful? Give feedback.
-
|
This won't affect support as the patches will still be relevant for the foreseeable future but it is what it is... |
Beta Was this translation helpful? Give feedback.
-
|
Saw the drama in the rvx lite channel. Sad to see the project being discontinued but as you said it is what it is. |
Beta Was this translation helpful? Give feedback.
-
|
Official ReVanced Extended Discontinuation Announcement and Closing Words by Inotia00. https://github.com/inotia00/revanced-documentation/wiki/Announcement Of no concern for the time being, but something to watch for the coming months as patches become disfuncional with breaking changes. |
Beta Was this translation helpful? Give feedback.
-
|
I've been watching these, was also gonna comment to you about them earlier today, but I figured I'd should just wait and watch for more development, and the possibility of the author incorporating new Spoofing fixes either his own (he said he has been looking into it, with no success tho) or incorporating from up-upstream, once the RV-Team fixes it. But hey, that's why the Custom Resources feature was implemented, it's now easy to use any patches even your own local repo files ❤️ Won't ask for it but kinda referencing again the viability of patching totally custom applications as well, just to make the tool totally independent/future proof. |
Beta Was this translation helpful? Give feedback.
-
|
I already have it in my mind. But Now sure when though. |
Beta Was this translation helpful? Give feedback.
-
|
It's supported now. You can patch any application with the tool. See example env here and docs here |
Beta Was this translation helpful? Give feedback.
-
|
Btw, what'll be to replace the Probably, an arbitrary valid upper-cased string which doesn't associate with the official repository packages. |
Beta Was this translation helpful? Give feedback.
-
Anything (upper cased) , other than the supported app names. See the .env.example file where I'm building YouTube Revancify Red. |
Beta Was this translation helpful? Give feedback.
-
|
@nikhilbadyal
...but now it is:
This is gonna cause issues when patching with the official ReVanced CLI in their next stable ReVanced/revanced-cli release if it reflects their pre-release changes so far. It will cause a divide since RVX/ReX use the previous structure, so the command isn't gonna be universally the same just with different resources anymore. |
Beta Was this translation helpful? Give feedback.
-
|
Ah, Another episode of making life harder. I think they should support both, Hope all the fork maintainers update their fork. I don't see any elegant way to support both types of patching. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, I too don't understand these new changes. If a user is using the CLI, I believe that they must be aware of that environment and don't have problems with basic complexities. Just like Patch naming wasn't necessary and a possible worst decision, this too falls under the same category. The last resort is that YT-Adv must fork inotia00's cli and push necessary changes to that because there's no api or data set to determine what the CLI arguments are. |
Beta Was this translation helpful? Give feedback.
-
This at the very least. Think we are able to open an issue at least to ask for keeping It's honestly such a pointless change, I don't understand the reason of half of the stuff oSum and the core team do, and the other half I just disagree... |
Beta Was this translation helpful? Give feedback.
-
revanced supports these apps. please add them
https://play.google.com/store/apps/details?id=net.binarymode.android.irplus
https://play.google.com/store/apps/details?id=com.dci.dev.androidtwelvewidgets
https://play.google.com/store/apps/details?id=com.microblink.photomath
https://play.google.com/store/apps/details?id=io.yuka.android
https://play.google.com/store/apps/details?id=com.teslacoilsw.launcher
Beta Was this translation helpful? Give feedback.
All reactions