Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On state result pages, should the "a note about this election" box appear grouped w/ the main content / not above the ad? #112

Open
alykat opened this issue Oct 29, 2020 · 2 comments
Open

On state result pages, should the "a note about this election" box appear grouped w/ the main content / not above the ad? #112

alykat opened this issue Oct 29, 2020 · 2 comments
Assignees
@thomaswilburn
Labels
polish

Comments

@alykat
Copy link
Member

alykat commented Oct 29, 2020

Like this but tidier:

image
@alykat alykat added the polish label Oct 29, 2020
@thomaswilburn
Copy link

The ad lives in the same div as the app, for state pages, but the about box is just part of the regular index.html markup. It may be possible to make this work but I'll have to think about it.

@thomaswilburn thomaswilburn self-assigned this Oct 29, 2020
@alykat
Copy link
Member Author

alykat commented Oct 29, 2020 •
edited
Loading

Low-pri / if it's not a heavy lift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomaswilburn thomaswilburn

Labels
polish
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alykat @thomaswilburn