Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable front-page advisor #61

Open
Mierdin opened this issue Jun 11, 2020 · 0 comments
Open

Re-enable front-page advisor #61

Mierdin opened this issue Jun 11, 2020 · 0 comments

Comments

@Mierdin
Copy link
Member

Mierdin commented Jun 11, 2020

In #60 I commented out the front-page advisor component, since it doesn't currently work. This gives a pretty bad first impression to new users, so I'd rather they not see it until it works properly.

#28 highlights that this component uses a very old version of the antidote.js script via a commit ID in antidote-web, and it's possible that in solving that issue, this may be solved as well.

There have been CORS issues for a long time. On chrome in incognito, it seems this was intermittent originally. However, in FF these days this seems more pronounced.

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://go.nrelabs.io/syringe/exp/lesson. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

The other main issue is that this uses the old /syringe path, which is another artifact of using an old version of antidote-web.

Once #28 is fixed, we should re-enable this and ensure no CORS issues remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant