Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon): use optional chaining to fix 'undefined' error in Histoire #225

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix(icon): use optional chaining to fix 'undefined' error in Histoire #225

merged 1 commit into from
Jul 30, 2024

Conversation

tkjaergaard
Copy link
Contributor

@tkjaergaard tkjaergaard commented Jul 30, 2024 •
edited
Loading

🔗 Linked issue

Partially fixes #212 when css. This PR dosen't resolve issues in svg.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When using the Icon component in Histoire, an error is thrown in css.js due to the lack of optional chaining in the getIcon function.

@antfu antfu merged commit a64428c into nuxt:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@nuxt/icon not working in histoire with mode "svg"
2 participants
@tkjaergaard @antfu