Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new runtime freshness info #892

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use new runtime freshness info #892

wants to merge 1 commit into from

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Sep 26, 2023

Closes #882.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 473a245996d8fc4edd767a2fffe47999f64d647d
Status:✅ Deploy successful!
Preview URL: https://c2b1cf63.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/better-freshness-data branch from 99c2700 to 2d06b31 Compare September 26, 2023 08:40
@csillag csillag marked this pull request as ready for review September 26, 2023 08:43
@csillag
Copy link
Contributor Author

csillag commented Sep 26, 2023

Turns out that the new field doesn't really mean what I thought it meant. This needs to be clarified.

@csillag csillag marked this pull request as draft September 26, 2023 12:21
@csillag csillag force-pushed the csillag/better-freshness-data branch 4 times, most recently from 376b64e to 10c6957 Compare September 26, 2023 12:52
@csillag csillag marked this pull request as ready for review September 26, 2023 12:53
@csillag
Copy link
Contributor Author

csillag commented Sep 26, 2023

OK, should be fine now. (Following @Andrew7234's suggestion)

@csillag
Copy link
Contributor Author

csillag commented Sep 27, 2023

According to today's meeting, we want to refine this some more, so I'm putting this back to draft state.

@csillag csillag marked this pull request as draft September 27, 2023 15:16
@csillag
Also use block numbers when datermining freshness
473a245 
Besides looking at the block times, also compare
latest_block with latest_node_block
@csillag csillag force-pushed the csillag/better-freshness-data branch from 10c6957 to 473a245 Compare September 27, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d Awaiting requested review from lukaw3d lukaw3d is a code owner

@buberdds buberdds Awaiting requested review from buberdds buberdds will be requested when the pull request is marked ready for review buberdds is a code owner

@lubej lubej Awaiting requested review from lubej lubej will be requested when the pull request is marked ready for review lubej is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new /status fields
1 participant
@csillag