Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar layout breaks at 769 width #1881

Open
lukaw3d opened this issue Apr 9, 2024 · 1 comment
Open

Toolbar layout breaks at 769 width #1881

lukaw3d opened this issue Apr 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@lukaw3d
Copy link
Member

lukaw3d commented Apr 9, 2024

For window sizes 769 .. 783 the toolbar layout is broken

Peek.2024-04-09.18-15.mp4
@lukaw3d lukaw3d added the bug Something isn't working label Apr 9, 2024
@lukaw3d
Copy link
Member Author

lukaw3d commented Apr 9, 2024

When window width is 769 document.body.clientWidth returns 754 (maybe scrollbar width difference?)

Toolbar uses media queries https://github.com/oasisprotocol/oasis-wallet-web/blob/3ea48a2730d4e48daf2f6b4d477da5eea7834431/src/app/components/Toolbar/index.tsx#L23

Grommet ResponsiveContext uses document.body.clientWidth
https://github.com/grommet/grommet/blob/feb323b0a25c6b6e908fb3bb3210575928680760/src/js/components/Grommet/Grommet.js#L131-L140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant