Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple issues with retinal photopic cells #2245

Open
cmungall opened this issue Dec 18, 2023 · 1 comment
Open

Multiple issues with retinal photopic cells #2245

cmungall opened this issue Dec 18, 2023 · 1 comment

Comments

@cmungall
Copy link
Member

There are many issues with the classification of terms highlighted in the image below:

image

(drawn with OAK and cl viz -p i --down CL:0000490 CL:0000749 "OFF-bipolar cell" CL:0000573)

  • why is retinal cone cell not classified under retinal cell?
  • why is photopic receptor cell not classified under visual system neuron?
  • why isn't ON-blue cone bipolar cell not classified under retinal cone cell?
  • the classification of photopic receptor cell seems massively incomplete?
  • etc

Overall it looks like there are just too many axes of classification going on with insufficient axiomatization to render them complete

In some cases it seems like CL has grouping classes that are just inherently hard to make complete. E.g. my understanding is that role in photopic vision is not discrete. cones are typically photopic, rods typically scotopic, but this is not all or nothing (if it were, then there would be no need for a distinct "photopic receptor cell" classification)

Some of these groupings may be historic - e.g it looks like both photopic and scotopic receptor cells have been there from the early days of CL, and they are undefined. These could probably be obsoleted.

The classification here appears wrong:

  • [] CL:0000210 ! photoreceptor cell
    • [i] CL:0000489 ! scotopic photoreceptor cell
    • [i] CL:0000488 ! visible light photoreceptor cell
      • [i] CL:0000490 ! photopic photoreceptor cell

AFAIK, both scotopic and photopic are visible, the distinction is to do with light levels. visible light photoreceptor cell is also massively incomplete - other than photopic, it only has fly neurons.

I can see a number of challenges with making axiomatization complete here related to species specificity. There is a lot of tacit information to navigate around; we have the terrible GO-ish "camera-type eye" which needs to be fixed in GO and Uberon, there is also the fact that "retina" is used for the vertebrate structure, and the more generic photoreceptor array used for adult Drosophila retinal cells. And there are the usual annoying exceptions to photoreceptors being found in retinas. In fact CL:0000210 photoreceptor cell could technically be used by PO.

This is all compounded by the different uses of has-soma-location vs part of in the ontology...

cmungall added a commit that referenced this issue Dec 18, 2023
See #2245

Note that this is a hidden GCI, which acts as a rule - I
don't there are photoreceptors in a vertebrate eye that are
not in the retina
@dosumis
Copy link
Contributor

dosumis commented Dec 21, 2023

I'm dubious about many grouping classes here:

Suggested obsoletions:

Keep but prune:

  • visible light photoreceptor
  • UV light photoreceptor

Remove all insect photoreceptors from under these terms:
Which cell is specialised to respond to which frequencies will vary with species (it's entirely possible that in some insects, R7 does not respond to UV), so I think CL should not have much under these terms. But single species cell type ontologies might find them useful, esp as we have patterns using GO.

why isn't ON-blue cone bipolar cell not classified under retinal cone cell?

because it aint a cone cell, it's a bipolar cell downstream of a cone cell

why is photopic receptor cell not classified under visual system neuron?

photoreceptor cell should be - inferred from axiomatization.

Can be fixed by switching definition of photoreceptor cell:

image

Text def should refer to visual perception.

Axiomtization should use 'detection of light stimulus involved in visual perception'

This will be sufficient for inference under 'visual system neuron'. Ticket here #2253

dosumis added a commit that referenced this issue Mar 5, 2024
See #2245

Note that this is a hidden GCI, which acts as a rule - I
don't there are photoreceptors in a vertebrate eye that are
not in the retina

Co-authored-by: David Osumi-Sutherland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants