Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2460 revise def multiciliated epithelial cell #2482

Merged
merged 22 commits into from
Sep 16, 2024

Conversation

Caroline-99
Copy link
Collaborator

@Caroline-99 Caroline-99 commented Aug 8, 2024

Fixes #2460

  • Pato term (PATO_0010007 multiciliated) is imported into CL
  • text definition updated and references added
  • logical definition updated

Related to pato-ontology/pato#561 - PATO term has been approved and the imports have been refreshed

- Pato term (PATO_0010007 multiciliated) is imported into CL (note this term has not been approved by PATO yet)
-text defintion updates and references added
-logical defintion updated
@Caroline-99 Caroline-99 linked an issue Aug 8, 2024 that may be closed by this pull request
@Caroline-99 Caroline-99 self-assigned this Aug 8, 2024
@anitacaron
Copy link
Contributor

#gogoeditdiff

@anitacaron
Copy link
Contributor

Do you need help updating imports to have PATO correctly imported?

Copy link

github-actions bot commented Aug 12, 2024

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-06/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-06/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4047001 http://purl.obolibrary.org/obo/CL_4047001

Added

created by http://www.geneontology.org/formats/oboInOwl#created_by

Removed

creation date http://www.geneontology.org/formats/oboInOwl#creation_date

Removed

has part http://purl.obolibrary.org/obo/BFO_0000051

Removed

id http://www.geneontology.org/formats/oboInOwl#id

Removed

multi-ciliated epithelial cell http://purl.obolibrary.org/obo/CL_0005012

Removed

Added

part of http://purl.obolibrary.org/obo/BFO_0000050

Removed

Copy link

github-actions bot commented Aug 12, 2024

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

PATO_0010007 http://purl.obolibrary.org/obo/PATO_0010007

Added

multi-ciliated epithelial cell http://purl.obolibrary.org/obo/CL_0005012

Removed

Added

Copy link
Collaborator

@JABelfiore JABelfiore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition and references look good, one minor amend.

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
Copy link
Collaborator

@AvolaAmg AvolaAmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this paper they are referring to Multiciliated ependymal (E1) cells and (and other two type of ciliated cell E2, E3).
Would you like to have a look at this paper to see if Mutliciliated ependymal cell should be added as an NTR with parent term multi-ciliated epithelial cell ?

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
Copy link
Collaborator

@AvolaAmg AvolaAmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see in line comments.

@anitacaron anitacaron added the update-imports-required Imports need to be refreshed before this PR can be merged. label Aug 16, 2024
@Caroline-99
Copy link
Collaborator Author

#gogoeditdiff

@Caroline-99 Caroline-99 merged commit 83c9e2f into master Sep 16, 2024
1 check passed
@Caroline-99 Caroline-99 deleted the 2460-revise-def-multiciliated-epithelial-cell branch September 16, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-imports-required Imports need to be refreshed before this PR can be merged.
Projects
Development

Successfully merging this pull request may close these issues.

Revise def multiciliated epithelial cell
5 participants