Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid identifiers with auto-generated code #6

Open
darioteixeira opened this issue Dec 19, 2016 · 1 comment
Open

Invalid identifiers with auto-generated code #6

darioteixeira opened this issue Dec 19, 2016 · 1 comment

Comments

@darioteixeira
Copy link

I came across this problem after invoking obus-introspect -system -rec org.bluez /org/bluez and then obus-gen-client. The generated code required some manual tweaking for two different reasons:

  1. It produced a function named class (reserved word in OCaml).
  2. It produced a value named UUID (yep, uppercase).

Nothing major. Nevertheless, it would be nice if the auto-generated code would be free from such issues.

@ghost
Copy link

ghost commented Dec 19, 2016

Indeed, it would be better to produce valid OCaml code. I'll try to have a look at some point, i haven't touched this code in a very long time... Alternatively do you think you could submit a PR? The code to update is in tools/obus_gen_{client,server}.ml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant