Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Hub is missing the -0 suffix on the first image for a tag #71

Open
manics opened this issue Jul 1, 2022 · 2 comments
Open

Docker Hub is missing the -0 suffix on the first image for a tag #71

manics opened this issue Jul 1, 2022 · 2 comments

Comments

@manics
Copy link
Member

manics commented Jul 1, 2022

https://hub.docker.com/r/openmicroscopy/omero-web-standalone/tags

- name: Get other tags
id: gettags
uses: jupyterhub/[email protected]

only creates higher-level tags, so if this repository is tagged with 5.14.0 instead of 5.14.0-0 the Docker Hub tags 5.14.0 and 5.14 are created, and 5 is updated.

If the image is later rebuilt and tagged as 5.14.0-1 Docker Hub tags 5.14.0, 5.14 and 5 are updated, but since there was never a 5.14.0-0 tag the original 5.14.0 image is lost.

This also applies to https://hub.docker.com/r/openmicroscopy/omero-server/tags

@jburel
Copy link
Member

jburel commented Jul 4, 2022

Thanks for the info.
Are you working on that issue in the action?

Checking https://github.com/jupyterhub/action-major-minor-tag-calculator/blob/main/README.md
Pushed reference "1.2.3-4" => tags output "[1.2.3-4, 1.2.3, 1.2, 1, latest]"

@manics
Copy link
Member Author

manics commented Jul 8, 2022

No, I think this is best handled when the GitHub *-docker repository is tagged. Extrapolating a release tag of 5.14.0 to 5.14.0-0 is doable, but since rebuilds of the Docker image will need a -1, -2, ... etc GitHub tag anyway it seems more consistent to start with a -0 GitHub tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants