Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show _what_ props change when in debug-mode #132

Open
torgeir opened this issue May 25, 2016 · 3 comments
Open

Show _what_ props change when in debug-mode #132

torgeir opened this issue May 25, 2016 · 3 comments

Comments

@torgeir
Copy link
Member

torgeir commented May 25, 2016

It would be useful if the .debug() options on omniscient and shouldComponentUpdate outputted what props changed, instead of just => true (props have changed).

This would ease fixing stuff like unnescessary renders that happen because of changed passed function references, and help show when you'd benefit from something like omnipotent's ignore

@mikaelbr
Copy link
Member

So you are thinking diffing the two states/props? That could work, but should only happen when it has changed.

@torgeir
Copy link
Member Author

torgeir commented May 25, 2016

Yep, that's where debug log already occurs. Diffing or not, it would be useful to pinpoint the prop that changed, so it's thrown right in your face 👊 We already know something changed, we might as well say what, so there's no need for digging around..

@mikaelbr
Copy link
Member

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants