Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incubating OTel APIs can't be used it the agent #12128

Open
zeitlinger opened this issue Aug 28, 2024 · 1 comment · May be fixed by #12230
Open

incubating OTel APIs can't be used it the agent #12128

zeitlinger opened this issue Aug 28, 2024 · 1 comment · May be fixed by #12230
Assignees
Labels
enhancement New feature or request

Comments

@zeitlinger
Copy link
Member

zeitlinger commented Aug 28, 2024

Is your feature request related to a problem? Please describe.

ApplicationTracer doesn't implement ExtendedTracer - similar for other APIs

https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/opentelemetry-api/opentelemetry-api-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opentelemetryapi/trace/ApplicationTracer.java

In the SDK, there's a similarly surprising problem: open-telemetry/opentelemetry-java#6617

A first part (for metrics) was already implemented in the agent: #11934
The second part (that also covers noop) can be implemented once the SDK issue has been fixed.

Why the dependency?
The agent uses noop if there are no readers registered: https://github.com/open-telemetry/opentelemetry-java/blob/c33febbea6250d771d2081637764c25ddd071875/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkMeterProvider.java#L111

Describe the solution you'd like

User should be able to just use incubating API if they add the dependency

Describe alternatives you've considered

No response

Additional context

No response

@zeitlinger zeitlinger added the enhancement New feature or request label Aug 28, 2024
@zeitlinger zeitlinger self-assigned this Aug 28, 2024
@zeitlinger
Copy link
Member Author

there might be a merge conflict with #12186

@laurit laurit linked a pull request Sep 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant