xtokens weights

[sander2]

Xtokens extrinsics weight is determined like this:

open-runtime-module-library/xtokens/src/lib.rs

Lines 214 to 215 in 19afb58

	#[pallet::weight(XtokensWeight::<T>::weight_of_transfer(currency_id.clone(), *amount, dest))]
	pub fn transfer(

Where the weight pretty much boils down to the weight of the equivalent xcm message:

open-runtime-module-library/xtokens/src/lib.rs

Lines 860 to 877 in 19afb58

	let mut msg = match transfer_kind {
	SelfReserveAsset => Xcm(vec![TransferReserveAsset {
	assets: vec![asset].into(),
	dest,
	xcm: Xcm(vec![]),
	}]),
	ToReserve | ToNonReserve => Xcm(vec![
	WithdrawAsset(MultiAssets::from(asset)),
	InitiateReserveWithdraw {
	assets: All.into(),
	// `dest` is always (equal to) `reserve` in both cases
	reserve,
	xcm: Xcm(vec![]),
	},
	]),
	};
	return T::Weigher::weight(&mut msg)
	.map_or(Weight::max_value(), |w| T::BaseXcmWeight::get().saturating_add(w));

Wouldn't this underestimate the weight, since it doesn't account for a bunch of logic that constructs the actual message?

[xlc]

Yeah we need some improvement on this.