Set horizon_minutes as NOT NULL

[simlmx]

We should enforce horizon_minutes to be NOT NULL. This will require a data migration where we calculate the horizon based on the timestamp_utc of the forecast and the start_utc time of the forecast_value.

pv-site-datamodel/pvsite_datamodel/sqlmodels.py

Line 210 in 11080b3

# TODO Set to nullable=False

[Chirag-01]

Hi @simlmx ,
I was going through this issue for GSOC 2024 contribution. So we just need to change one line 213 to fix this?

[simlmx]

In theory yes but in practice this will require a corresponding migration for production environment where this is used. I don't have access to those anymore. Also I don't know if changing this is still relevant. @peterdudfield would know more!

[peterdudfield]

Yea, we just need to write a script that would look at start_utc and created_utc and calculate the horizon minutes. I can always do that script, if @Chirag-01 you fancy doing the migration