Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for standard joins #30

Open
rjmartell opened this issue May 6, 2016 · 4 comments · May be fixed by #197
Open

Add tests for standard joins #30

rjmartell opened this issue May 6, 2016 · 4 comments · May be fixed by #197

Comments

@rjmartell
Copy link
Contributor

rjmartell commented May 6, 2016

The relevant conformance class is Standard joins: "The server shall implement join predicates using all Filter operators except the spatial and temporal operators." See A.1.11.

All tests are skipped if the service constraint ImplementsStandardJoins is "FALSE" in the capabilities document.

@keshavnangare
Copy link

@dstenger @ghobona

I checked the above-referred document and it refers to the OGC 09-026r2 document. Please find below screenshot from the referred document:

image

The A.5 and A.6 requirements from the OGC 09-026r2 document are as below and implemented PropertyIsEqualToOperatorTests, ComparisonOperatorTests, PropertyIsLikeOperatorTests, PropertyIsNilOperatorTests and PropertyIsNullOperatorTests classes of ETS.

image

I did not find any test implementation for the operator PropertyIsBetween.

@ghobona
Copy link
Contributor

ghobona commented Mar 24, 2021

@keshav-nangare please implement the test for the operator PropertyIsBetween.

@keshavnangare
Copy link

@ghobona

I am implementing the PropertyIsBetween operator test. As per the OGC 09-026r2 specification:

7.7.3.7 PropertyIsBetween operator
The PropertyIsBetween element is defined as a compact way of encoding a range check. The lower and upper boundary values are inclusive.

I found the below example to create a request but unable to select lower and upper boundary values from the features. Can you please provide one of the example to set lower and upper boundary values?

<fes:Filter
   xmlns:fes="http://www.opengis.net/fes/2.0"
   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
   xsi:schemaLocation="http://www.opengis.net/fes/2.0
   http://schemas.opengis.net/filter/2.0.02.0/filterAll.xsd">
   <fes:PropertyIsBetween>
      <fes:ValueReference>DEPTH</fes:ValueReference>
      <fes:LowerBoundary>
         <fes:Literal>100</fes:Literal>
      </fes:LowerBoundary>
      <fes:UpperBoundary>
         <fes:Literal>200</fes:Literal>
      </fes:UpperBoundary>
   </fes:PropertyIsBetween>
</fes:Filter>

@keshavnangare keshavnangare linked a pull request Apr 7, 2021 that will close this issue
@keshavnangare
Copy link

I have added changes to make a request for the PropertyIsBetween operator. Please find the changes in #197 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

7 participants