Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Instant, Interval, Object modeling #177

Open
hylkevds opened this issue Feb 20, 2024 · 2 comments
Open

Time Instant, Interval, Object modeling #177

hylkevds opened this issue Feb 20, 2024 · 2 comments
Labels
data model sensing v2.0 This change should be discussed for v2.0 of the sensing document.

Comments

@hylkevds
Copy link
Contributor

In STAv1.1 we have:

  • TM_Instant (2018-01-01T02:00:00Z)
  • TM_Interval (2018-01-01T02:00:00Z/2018-01-01T03:00:00Z)
  • TM_Object
    • Either an Instant or an Interval

OData only defines TM_Instant (EDM_DateTimeOffset), not intervals.

The proposal is to model TM_Object as a complex property with a start (mandatory) and an end (optional).

Disadvantage is that even if the Observation phenomenonTime is an instant, you'll still see an object with a "start" property.

@hylkevds hylkevds added sensing v2.0 This change should be discussed for v2.0 of the sensing document. data model labels Feb 20, 2024
@hylkevds
Copy link
Contributor Author

A second point is the names we use for times. Currently the proposal has:

  • Datastream/phenomenonTime
  • Datastream/resultTime
  • Observation/phenomenonTime
  • Observation/resultTime
  • Observation/validTime
  • Deployment/deploymentTime
  • HistoricalLocation/time
  • PreparationStep/time
  • Sampling/samplingTime

This is rather inconsistent, since sometime just time is used, while sometimes the name is spelled out completely (deploymentTime, samplingTime). For the Datastream and Observation it is obvious a shorter name can not be used, since there are multiple times, but Deployment, HistoricalLocation, PreparationStep and Sampling all only have one time.

We could either

  1. Use time for these four times
  2. Use the full name for these four, but what name to use?
    • historicalLocationTime and preparationStepTime are very ugly.
    • HistoricalLocation/arrivalTime? That would be semantically clearer.
    • PreparationStep/executionTime?

@hylkevds
Copy link
Contributor Author

hylkevds commented Mar 13, 2024

There is a preference for the short versions.
Also samplingLocation -> location

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data model sensing v2.0 This change should be discussed for v2.0 of the sensing document.
Projects
None yet
Development

No branches or pull requests

1 participant