Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] setting maxSurge and partition, cloneset's behavior is not suitable #286

Closed
shiyan2016 opened this issue Jun 10, 2020 · 7 comments
Closed
Assignees
Labels
kind/bug Something isn't working

Comments

@shiyan2016
Copy link
Member

What happened:
Create a cloneset with replicas 8, partition 6, maxSurge 50% and maxUnavaliable 0. Do some update for the cloneset pod template, it will create 8*50%=4 update pod, and after ready delete 4+2=6 pod.

What you expected to happen:
During the update, the update pod creation should not
exceed maxSurge and replicas-partition. In this case, just create 2 update pod, after ready delete 2+2=4 pod.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kruise version: v0.5.0
  • Kubernetes version (use kubectl version): v1.17.4
  • OS (e.g: cat /etc/os-release): ubuntu 16.04
@shiyan2016 shiyan2016 added the kind/bug Something isn't working label Jun 10, 2020
@FillZpp
Copy link
Member

FillZpp commented Jun 10, 2020

@shiyan2016 What a coincidence! @fatedier and I just talked about this yesterday.

He has submitted a PR to fix it #285

@shiyan2016
Copy link
Member Author

Ok. That's great. I will pay attention to the PR #285.

@FillZpp
Copy link
Member

FillZpp commented Jun 10, 2020

@shiyan2016 Hi, the PR has been merged. It should be released in v0.5.1 this month.

@shiyan2016
Copy link
Member Author

@FillZpp When will v0.5.1 be released?

@FillZpp
Copy link
Member

FillZpp commented Jun 16, 2020

@shiyan2016 Hi, it will be released next week.

By the way, to get more feedback of Kruise's adoption in industry, would you mind helping comment in issue #289 to give more information about your enterprise's Kruise usage. Thanks a lot in advance. 😄

@shiyan2016
Copy link
Member Author

@FillZpp How about the v0.5.1 release ?

@FillZpp
Copy link
Member

FillZpp commented Sep 1, 2020

Already fixed in v0.6.0.

@FillZpp FillZpp closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants