Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for compilation / Makefile execution #30

Open
p0pr0ck5 opened this issue Oct 18, 2016 · 7 comments
Open

Support for compilation / Makefile execution #30

p0pr0ck5 opened this issue Oct 18, 2016 · 7 comments

Comments

@p0pr0ck5
Copy link

Any plans to support OPM packages to execute install commands when installed via opm? E.g. a package could execute a command to locally make some C module as part of the installation process, similar to what Luarocks offers.

@agentzh
Copy link
Member

agentzh commented Oct 18, 2016

@p0pr0ck5 Support for Lua libraries with C components are already planned. See our TODO list:

https://github.com/openresty/opm#todo

But we won't use the author Makefile since Makefiles are non-portable per se. We will provide our own mechanism in opm.

@isage
Copy link

isage commented Aug 28, 2017

we won't use the author Makefile since Makefiles are non-portable per se. We will provide our own mechanism in opm.

I, for example, use CMake. And CMake is portable. As an author, it would be a burden to me to maintain some different (opm) build system configuration alongside cmake one.

@agentzh
Copy link
Member

agentzh commented Aug 28, 2017

@isage cmake is an extra dependency that I never like.

@isage
Copy link

isage commented Aug 29, 2017

Yes, but let's take LuaRocks, for example: i can use any build system i want. Makefiles, CMake or just describe build steps in rockspec. That way i can reuse my already existing build scenario.
If external build systems won't be supported i'd rather not support opm and, provided opm supports LuaRocks at some point, support just LuaRocks.

@agentzh
Copy link
Member

agentzh commented Aug 29, 2017

@isage The use of LuaRocks is deprecated in OpenResty. Opm decides to do its own build system for C components, in a very portable way.

@isage
Copy link

isage commented Aug 29, 2017

I've meant luarocks/ namespace support, as mentioned in TODO.
As for portability, well, opm can't be used outside of openresty, can't be used for creating deb/rpm/etc., so.
Point is, i, as a module author, wouldn't want to maintain both CMake/Makefile/Whatever build config and opm one. Or ditch first in favor of opm.

@agentzh
Copy link
Member

agentzh commented Aug 29, 2017

@isage Well, the LuaRocks libraries' config will get converted to opm's build system, at least for simple ones. That's how the compatibility will work out. Opm will never run LuaRock module's own build systems directly on opm clients' machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants