Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] When using go-sdk to subscribe all RouterTraffic CR in current namespace, what 'app' param should be? #29

Open
LaurenceLiZhixin opened this issue Feb 4, 2023 · 1 comment
Labels
kind/question Further information is requested

Comments

@LaurenceLiZhixin
Copy link

// NewSubscribeKey returns an instance of SubscribeKey which is constructed by parameters.
func NewSubscribeKey(namespace string, app string, configKind configkind.ConfigKind) *SubscribeKey {
	return &SubscribeKey{
		namespace: namespace,
		app:       app,
		kind:      configKind,
	}
}

How I can subscribe all crs in current ns?

@jnan806
Copy link
Collaborator

jnan806 commented Feb 5, 2023

In most scenes, RouterTraffic CRs were defined in a certain application scope, so we have a convention that, the label app in CR is required.
So in current version you should give both namespace and app to defined your target CR, and you should subscribe all configKind one by one in your framework or application if you want to subscribe all CRs in the given namespace and app.

We also welcome you to append your opinions and your designs in this ISSUE 😃

@sczyh30 sczyh30 added the kind/question Further information is requested label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants