Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reuse mechanism for OpenSergoClient #31

Open
jnan806 opened this issue Feb 6, 2023 · 1 comment · May be fixed by #34
Open

Add reuse mechanism for OpenSergoClient #31

jnan806 opened this issue Feb 6, 2023 · 1 comment · May be fixed by #34
Labels
kind/feature Category issues or PRs related to feature request

Comments

@jnan806
Copy link
Collaborator

jnan806 commented Feb 6, 2023

Issue Description

Type: feature request

Describe what feature you want

In current version, OpenSergoClient uses prototype mode.
SDK will create a new instance when invoke NewOpenSergoClient, even if the endpoint is the same.
It is very expensive without reuse mechanism, so we need a reuse mechanism to avoid it.

@jnan806 jnan806 added the kind/feature Category issues or PRs related to feature request label Feb 6, 2023
@mayooot mayooot linked a pull request Mar 27, 2024 that will close this issue
@mayooot
Copy link

mayooot commented Mar 27, 2024

@jnan806 Hi, I use a map with host:port as key and openSergoClient as value to control reuse, and use sync.map to avoid concurrent access problems.

I think it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Category issues or PRs related to feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants