Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argon2-opencl should support longer passwords #5523

Open
solardiz opened this issue Aug 13, 2024 · 3 comments
Open

argon2-opencl should support longer passwords #5523

solardiz opened this issue Aug 13, 2024 · 3 comments

Comments

@solardiz
Copy link
Member

Right now, argon2-opencl is unnecessarily limited by its PLAINTEXT_LENGTH 100. We should probably bump this to our usual maximum of 125, unless there's any specific reason to keep it at 100, @alainesp?

@solardiz
Copy link
Member Author

Patched to 125, still works (using a CMIYC 2024 hash on an ancient machine):

$ ./john -mask='Adity?l?s?d?d?d?d' pw-argon2id
Device 1: GeForce GTX 570
Using default input encoding: UTF-8
Loaded 1 password hash (argon2-opencl [Blake2 OpenCL])
Cost 1 (t) is 1 for all loaded hashes
Cost 2 (m) is 65536 for all loaded hashes
Cost 3 (p) is 4 for all loaded hashes
Cost 4 (type [0:Argon2d 1:Argon2i 2:Argon2id]) is 2 for all loaded hashes
Trying to compute 18 hashes at a time using 1152 of 1279 MiB device memory
LWS=32 GWS=2304 (72 blocks) => Mode: LOCAL_MEMORY
Press 'q' or Ctrl-C to abort, 'h' for help, almost any other key for status
Aditya@2011      (?)
1g 0:00:00:39 DONE (2024-08-13 17:30) 0.02520g/s 263.5p/s 263.5c/s 263.5C/s Dev#1:68C Adityu 2011..Adityr@2011

@solardiz solardiz added this to the Definitely 2.0.0 milestone Aug 13, 2024
@alainesp
Copy link
Contributor

Right now, argon2-opencl is unnecessarily limited by its PLAINTEXT_LENGTH 100. We should probably bump this to our usual maximum of 125, unless there's any specific reason to keep it at 100, @alainesp?

There shouldn't be any problem, but I can't provide a guarantee. I can recheck the code this weekend if you need assurance.

@solardiz
Copy link
Member Author

Thanks @alainesp. I just wanted to know you don't recall any special reason for choosing 100. I don't see any limitations in the code. Ideally, we'd actually test with a length 125 password (generate such Argon2 hash on CPU).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants