Initial sync time doesn't include the final commit time

[gmart7t2]

Maybe consider switching the order of these two blocks:

    if starting_index_height == 0 && self.height > 0 {
      wtx.open_table(STATISTIC_TO_COUNT)?.insert(
        Statistic::InitialSyncTime.key(),
        &u64::try_from(start.elapsed().as_micros())?,
      )?;
    }

    if uncommitted > 0 {
      self.commit(wtx, utxo_cache)?;
    }

That final commit can take a long time, and should be included in the initial sync time.

[casey]

Good find! One issue though is that after the commit, the write transaction doesn't exist, so we would have to create a new write transaction, se the statistic, and commit again. How long does the final commit usually take?

[raphjaph]

It can take like 30mins sometimes I think

[casey]

I think we should just double-commit if it's the first commit. I.e., if it's the first commit and we just comitted, set the statistic and re-commit. The second commit should be very quick.

[raphjaph]

yes, the second one is negligable