Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the version restrictions on GAP_pkg_juliainterface_jll #870

Open
fingolfin opened this issue May 10, 2023 · 0 comments
Open

Loosen the version restrictions on GAP_pkg_juliainterface_jll #870

fingolfin opened this issue May 10, 2023 · 0 comments

Comments

@fingolfin
Copy link
Member

The goal was to ensure that we only pair versions of GAP.jl and GAP_pkg_juliainterface_jll which use matching C code. But sometimes rebuild or minor updates necessary. So I think we should loosen this here, and just be very careful about how we version GAP_pkg_juliainterface_jll.

The primary reason for the strict syncing of the C code is that we don't want our fallback code to kick in which re-compiles JuliaInterface.so from scratch if we notice that the C code deviates from the JLL. I guess we should make that code more robust by turning off that logic if GAP.jl is not dev'ed (and then just print a warning about the difference, but still proceed with crossed fingers). The same then would be used in Singular.jl (see oscar-system/Singular.jl#639 -- BTW @benlorenz if you have any feedback on that PR, I'd still be interested)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant