Replies: 1 comment
-
I would be in favour of 2 (and 3), which would align with my preferred solution for #1348. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Right now, the
intersect
methods for GAP groups and forSubQuo
(and presumably for certain other types, too) returns not just the intersection, but also embeddings of the intersection into the objects being intersected. (For GAP groups, these are actually not necessary, but that's not so important right now).Anyway, I don't like this, as it makes them behave differently compared to other
intersect
methods in Oscar and elsewhere in the Julia ecosystem. Yet of course there are situations where one really needs those embeddings (e.g. I assume this is the case for theSubQuo
method).Still, here are some ideas how we could let those
intersect
methods return just the intersection by default:with_embeddings::Bool=false
keyword argumentintersect_with_embeddings
variantsintersect(A,B) = C
, the embeddings would be "registered" as canonical mapsC \to A
resp.C \to B
, accessed via, say,canonical_map(C,A)
SubQuo
is attribute storing, so we could simply compute all those embeddings and store them as attributesThe advantage of 1 and 2 is that if the user is not interested in the embeddings, we don't even need to create them, while with 3 and 4 we'd probably have to always create them -- but then again that's not worse than what we do right now.
Beta Was this translation helpful? Give feedback.
All reactions