Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebRTC: h264 FU-A parse for both S and E flag #4139

Open
chai51 opened this issue Aug 9, 2024 · 1 comment
Open

WebRTC: h264 FU-A parse for both S and E flag #4139

chai51 opened this issue Aug 9, 2024 · 1 comment
Assignees
@winlinvip
Labels
WebRTC WebRTC, RTC2RTMP or RTMP2RTC.

Comments

@chai51
Copy link

chai51 commented Aug 9, 2024

Describe the bug
In RTC3984, the FU-A format only explains the timing when the S flag and the E flag appear, so when there are both the S flag and the E flag in a FU-A packet, this is also allowed.

Version
Any version

To Reproduce
Steps to reproduce the behavior:

  • Send a FU-A packet to SRS via WebRTC, with both the S and E flags set to 1.
  • In the process of webrtc2rtmp: when SrsRtcFrameBuilder::packet_video_rtmp parses the RTP packet, the length of the NALU is not written; the NALUnitLength read by SrsFormat::do_avc_demux_ibmf_format is an invalid value.

Screenshots
image
@winlinvip winlinvip self-assigned this Aug 12, 2024
@winlinvip winlinvip added the WebRTC WebRTC, RTC2RTMP or RTMP2RTC. label Aug 12, 2024
@winlinvip winlinvip changed the title WebRTC: h264 FU-A parse WebRTC: h264 FU-A parse for both S and E flag Aug 12, 2024
@winlinvip
Copy link
Member

Nice work! Would you please file an PullRequest to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winlinvip winlinvip

Labels
WebRTC WebRTC, RTC2RTMP or RTMP2RTC.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@winlinvip @chai51