Disable UTs for APB Temporarily. #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see unidling tests flaking: if i see a second one I am going to open an issue: https://github.com/ovn-org/ovn-kubernetes/actions/runs/5451066748/jobs/9917243947?pr=3741 |
|
May I suggest an alternative option to use XDescribe Instead of commenting the code? This options still has an exit code of 0 for the test and it reports the tests as pending rather than gone: Rather than: when running all the tests (assuming none is commented out). |
|
yes as discussed in meeting will use |
tssurya
force-pushed
the
disable-apb-uts-temporarily
branch
from
658639b
to
fc5ca9b
Compare
|
@jcaamano : this one is good once CI passes. |
|
@tssurya should the failing tests be disabled? |
|
@jcaamano : I think those are fine, if e2e's are failing since its a separate lane anyways people can ignore the whole lane.. the UTs are the ones blocking other PRs. cc @npinaeva @jordigilh : saving the e2e failure link here in case its useful: https://github.com/ovn-org/ovn-kubernetes/actions/runs/5462546420/jobs/9943298187?pr=3741 |
jcaamano
force-pushed
the
disable-apb-uts-temporarily
branch
from
fc5ca9b
to
d5d3506
Compare
jcaamano
approved these changes
Jul 5, 2023
Disable UTs for APB Temporarily till the feature is stabilized. Reason: UTs are very flaky. Each PR is needed a minimum of 3 close/open combinations and luck for CI to pass to even run e2e's. At this stage where other features are trying to get in before the deadline this process is painful. Signed-off-by: Surya Seetharaman <[email protected]>
jcaamano
force-pushed
the
disable-apb-uts-temporarily
branch
from
d5d3506
to
4a24833
Compare
|
|
I don't have permissions to do anything else. |
ahhh :( thanks @jcaamano for getting to this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
Disable UTs for APB Temporarily till the feature
is stabilized.
Reason: UTs are very flaky. Each PR is needed a
minimum of 3 close/open combinations and luck for CI
to pass to even run e2e's. At this stage where other features
are trying to get in before the deadline this process is painful.
At least if the retest flag was present it would be nice, closing/opening
PRs on github frequently - we don't know what the consequences of that
for bigger feature PRs are.. too muc of time consumption trying to get CI
to pass
cc @jordigilh : WDYT? I think you and @npinaeva are working to get it all fixed
but that may take 2 more weeks for merge, meanwhile I'd like to unblock CI.
cc @jcaamano