Remove stale LRSRs from default and network scopped cluster router #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/unit-testing
arghosh93
force-pushed
the
delete_stale_logical_route
branch
from
3b302b6
to
cd269e4
Compare
tssurya
added
the
area/core-kubernetes
arghosh93
force-pushed
the
delete_stale_logical_route
branch
from
cd269e4
to
661da18
Compare
arghosh93
force-pushed
the
delete_stale_logical_route
branch
from
661da18
to
263bd30
Compare
This commit is to effectively filter LRSR created for default cluster router and prevent deletion of any other required routes. Previous predicate was causing 2 LRSRs to be selected while execution of CreateOrReplaceLogicalRouterStaticRouteWithPredicate function and was causing one of the routes to be deleted upon ovnkube-controller restart. 10.244.0.0/16 100.64.0.4 src-ip 10.244.2.0/24 100.64.0.4 src-ip Upstream issue: ovn-org#4693 Signed-off-by: Arnab Ghosh <[email protected]>
This PR removes logical router static routes with stale IPs when join or transit switch IP gets changed as part of day 2 operation. ip4.dst == 10.244.0.0/24 , nexthop = 100.88.0.2 dst-ip ip4.dst == 100.64.0.2/16 , nexthop = 100.88.0.2 dst-ip ip4.dst == 10.244.0.0/16 , nexthop = 100.64.0.4 src-ip ip4.dst == 100.64.0.4 , nexthop = 100.64.0.4 dst-ip Signed-off-by: Arnab Ghosh <[email protected]>
arghosh93
force-pushed
the
delete_stale_logical_route
branch
from
263bd30
to
fe9519f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes logical router static routes with stale IPs when join or transit switch IP gets changed as part of day 2 operation.
ip4.dst == 10.244.0.0/24 , nexthop = 100.88.0.2 dst-ip
ip4.dst == 100.64.0.2/16 , nexthop = 100.88.0.2 dst-ip
ip4.dst == 10.244.0.0/16 , nexthop = 100.64.0.4 src-ip
ip4.dst == 100.64.0.4 , nexthop = 100.64.0.4 dst-ip
ip4.dst == 10.244.2.0/24 , nexthop = 100.64.0.4 src-ip
What this PR does and why is it needed
Which issue(s) this PR fixes
Fixes #4693 additionally.
Special notes for reviewers
How to verify it
Details to documentation updates
Description for the changelog
Does this PR introduce a user-facing change?