Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Adding action buttons to the detail view of each file #3641

Open
9 tasks
fesave opened this issue Apr 27, 2022 · 2 comments · May be fixed by #3655
Open
9 tasks

[FEATURE REQUEST] Adding action buttons to the detail view of each file #3641

fesave opened this issue Apr 27, 2022 · 2 comments · May be fixed by #3655
Labels
Estimation - 3 (M) Feature request

Comments

@fesave
Copy link
Contributor

fesave commented Apr 27, 2022

The purpose of this feature is to add three new buttons to the detail view and remove them from the toolbar menu.

We can follow the following design to perform this task:

Scribble:

known patterns / examples from other apps:

image

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 27, 2022 •
edited
Loading

If the file is already downloaded, the Download option should be replace for Open

Also, i'd rename Share for Open with to avoid confusions with the Sharing feature

@fesave fesave self-assigned this Apr 28, 2022
@fesave fesave added this to the 2.21-current milestone Apr 28, 2022
@davcres davcres assigned davcres and unassigned davcres Apr 28, 2022
@fesave fesave linked a pull request May 4, 2022 that will close this issue
Open
1 task
@fesave fesave linked a pull request May 4, 2022 that will close this issue
Adding action buttons to the detail view of each file #3655
Open
1 task
@jesmrec jesmrec added the Sprint label May 24, 2022
@jesmrec
Copy link
Collaborator

jesmrec commented May 27, 2022

Some issues to comment after checking the implementation at a glance (not QA). This is how it looks like:

File not downloaded File Downloaded
Screenshot 2022-05-27 at 14 13 45 Screenshot 2022-05-27 at 14 12 39

My considerations:

  • Open with icon is the same as the sharing one. i'd not use that one
  • When the file is downloaded, both options Open and Open with do the same. If the file is downloaded, i'd show only Open with and Send (at least, for the moment)
  • If the file is not downloaded, the Open with button does nothing.
  • I'd remove the separator. It does not look like good when the progress bar is displayed

@jesmrec jesmrec modified the milestones: 2.21-current, 2.22-next Jun 9, 2022
@jesmrec jesmrec removed the Sprint label Jun 10, 2022
@michaelstingl michaelstingl modified the milestones: 4.1 - Next, backlog Apr 13, 2023
@JuancaG05 JuancaG05 removed this from the backlog milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimation - 3 (M) Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding action buttons to the detail view of each file owncloud/android
5 participants
@michaelstingl @jesmrec @fesave @JuancaG05 @davcres