APPLY_FIXES and for PHP_PHPCSFIXER linter

[hirnschmalz]

Describe the bug
Violations found by PHP CS Fixer are not fixed.

To Reproduce
Steps to reproduce the behavior:

1. Create a .mega-linter.yml with the following content

APPLY_FIXES: all
ENABLE_LINTERS:
  - PHP_PHPCSFIXER

2. Run MegaLinter locally with npx mega-linter-runner --release v8.0.0 (I also tried npx mega-linter-runner --release v8.0.0 --fix)
3. See the output (which is not fixed)

Using cache file ".php-cs-fixer.cache".
   1) htdocs/packages/my-notifications/Classes/Notification/Notification.php (single_space_around_construct)
   2) htdocs/packages/my-crm/Classes/MyApi/Model/Lead/Lead.php (single_space_around_construct)
   3) htdocs/packages/my-crm/Classes/MyApi/Model/Lead/ContactDetails.php (single_space_around_construct)
   4) htdocs/packages/my-crm/Classes/MyApi/Model/Lead/LeadFieldsForCase.php (single_space_around_construct)
   5) htdocs/packages/my-crm/Classes/MyApi/Model/Lead/LeadSourceDetails.php (single_space_around_construct)
   6) htdocs/packages/my-crm/Classes/Utility/RegistryUtility.php (list_syntax)

Found 6 of 172 files that can be fixed in 0.551 seconds, 18.00 MB memory used

Expected behavior
PHP CS Fixer is called with fix (php php-cs-fixer.phar fix ...) and fixes the violations

[nvuillam]

@llaville any idea ? :)

[llaville]

@llaville any idea ? :)

yes I've already a solution.
sorry the fix is pending on my low priority todo list.
I'll propose a fix next week.

[echoix]

@llaville any idea ? :)

yes I've already a solution.

sorry the fix is pending on my low priority todo list.

I'll propose a fix next week.

Before forgetting, can you write what the fix consists about (in a sentence)

[llaville]

@llaville any idea ? :)

yes I've already a solution.
sorry the fix is pending on my low priority todo list.
I'll propose a fix next week.

Before forgetting, can you write what the fix consists about (in a sentence)

of course, but as I am AFK (just on phone now), I'll give you an answer in 90 minutes.

[llaville]

Here is my analysis of the situation :

I think origin of issue is located there https://github.com/oxsecurity/megalinter/blob/v8.0.0/megalinter/Linter.py#L1258-L1267

In case of PHP_CS_FIXER linter it's the same executable (without --dry-run option) that should run to apply fixes.
See definition at https://github.com/oxsecurity/megalinter/blob/v8.0.0/megalinter/descriptors/php.megalinter-descriptor.yml#L192-L193

Origin of this implementation came from PHPCS where there are two executables : one to check violation (phpcs) and another one to apply fixes (phpcbf)

Hope my quick explains are enough. Sorry i'm a bit tired tonight ;-)

[llaville]

I've a good new : I've prepared a fix for MegaLinter v8.0 and it seems that all run fines at least with PHP flavor (and PHP-CS-Fixer)
I need to rebuild a full version to see if there are some regressions with other linters.

I'll keep you aware.
Tomorrow, I'll be a bit busy, but I think I should be able to propose a PR in next 24/48 hours.

[llaville]

Here is a preview of results with risky rule(s) (need a special configuration that is not easy if we don't know the concept):
I'll give an explain on discussion on how to do it !

[llaville]

For MegaLinter Team members but also all users of PHP-CS-Linter, if you need help to configure this linter (for risky rules), please read this #3973

[llaville]

For MegaLinter Team, the PR 3974 is WIP because I've not apply all requires changes (CHANGELOG, build.sh contents) and more than that do more regression tests ....

Next to come on 24/48 hours

[llaville]

Thanks to CI that demonstrate the power of non-regression tests.

Even if it's ok for PHP, it seems that my fix has introduced errors with others linters. I'll have a check on these later now ... no more free time