Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

// being cut in the query #281

Open
simon-rad opened this issue Jun 30, 2017 · 1 comment
Open

// being cut in the query #281

simon-rad opened this issue Jun 30, 2017 · 1 comment

Comments

@simon-rad
Copy link

Hello, I'm using your great library.
We had to clone it and comment out this line
https://github.com/oyvindkinsey/easyXDM/blob/master/src/Core.js#L333

The reason is - we have a query parameter in URL

https://domain.com:443/myframe/index.html?access_token=cZRLiMjyBYPDOxCcE0MiGY/plMVI07VGlRkL46dWkI//+bhvu4MUFd8kB19nlWNt2fVoH2fU5Myq4AWhu76QdQ==

And sometimes access token can contain two slashes //, and it is cut by that part of the code. and the token is not valid anymore.
Maybe there is a way to skip that replacement? Or can I contribute and add a setting for that replacement?

@oyvindkinsey
Copy link
Owner

This is a bug, since this normalization is only intended to apply to the path component of the url, and not additional components such as the fragment.

This should be fixed such that logic similar to that on #338 was applied.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants