Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate add_ruleset and add_ruleset_string #263

Open
p0pr0ck5 opened this issue Feb 22, 2017 · 3 comments
Open

Deprecate add_ruleset and add_ruleset_string #263

p0pr0ck5 opened this issue Feb 22, 2017 · 3 comments
Assignees
@p0pr0ck5
Labels
enhancement modsec compatability
Milestone
v0.12

Comments

@p0pr0ck5
Copy link
Owner

Need to start a deprecation cycle for reading JSON data and moving over exclusively to SecRules consumption.
@p0pr0ck5 p0pr0ck5 self-assigned this Feb 22, 2017
@p0pr0ck5 p0pr0ck5 added this to the v0.12 milestone Feb 22, 2017
@p0pr0ck5
Copy link
Owner Author

Slating deprecation for v0.12. Will remove in v1.0.

@tzumby
Copy link

tzumby commented Jun 3, 2017

If I'm understanding this correctly, with this you load just one ruleset, right ? Something like REQUEST-903.9002-WORDPRESS-EXCLUSION-RULES.conf from the modsecurity rules.

lua_resty_waf.load_secrules("/path/to/secrules/ruleset_name")

How would waf:set_option("add_ruleset", {"rule1.conf", "rule2.conf}) work when you pass a table? Would you have multiple load_secrules for the different rules ?

@p0pr0ck5
Copy link
Owner Author

p0pr0ck5 commented Jun 5, 2017

Yeah, you can just call load_secrules multiple times. Or for convenience we can allow this to take a table, that's really
Just syntactic sugar :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0pr0ck5 p0pr0ck5

Labels
enhancement modsec compatability
Projects
None yet
Milestone
v0.12
Development

No branches or pull requests
2 participants
@tzumby @p0pr0ck5