Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenameMap in inlining.cpp does not preserve the original variable name. #4444

Open
fruffy opened this issue Feb 21, 2024 · 2 comments · May be fixed by #4683
Open

RenameMap in inlining.cpp does not preserve the original variable name. #4444

fruffy opened this issue Feb 21, 2024 · 2 comments · May be fixed by #4683
Assignees
@fruffy
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser) enhancement This topic discusses an improvement to existing compiler code.

Comments

@fruffy
Copy link
Collaborator

fruffy commented Feb 21, 2024

The original variable name is lost, leading to incorrect debugging and printing output.
@fruffy fruffy added enhancement This topic discusses an improvement to existing compiler code. core Topics concerning the core segments of the compiler (frontend, midend, parser) labels Feb 21, 2024
@fruffy fruffy self-assigned this Feb 21, 2024
@fruffy fruffy mentioned this issue May 24, 2024
Merged
@vlstill
Copy link
Contributor

vlstill commented May 24, 2024

I understand this is an older issue, but it would be really helpful to have an example code that makes this problem visible.

@fruffy
Copy link
Collaborator Author

fruffy commented May 24, 2024 •
edited
Loading

It's been a while, let me see whether I can reproduce this. It's a bit tricky because it happens only when grabbing/printing names from specific IR nodes.

@fruffy fruffy linked a pull request May 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fruffy fruffy

Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser) enhancement This topic discusses an improvement to existing compiler code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve the original name when renaming declarations in the inlining pass. p4lang/p4c
2 participants
@vlstill @fruffy