Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconnect 按鈕並未將原 tab 中的連線重設 #33

Open
Yi-Tseng opened this issue Apr 3, 2015 · 3 comments
Open

reconnect 按鈕並未將原 tab 中的連線重設 #33

Yi-Tseng opened this issue Apr 3, 2015 · 3 comments
Labels
enhancement

Comments

@Yi-Tseng
Copy link
Contributor

Yi-Tseng commented Apr 3, 2015

Hi

I think 'reconnect' function should let the session reconnect in 'original tab', not open a new tab.

Maybe we can close last tab and open a new tab for new connection.
@Yi-Tseng Yi-Tseng changed the title About "reconnect" function [Question] About "reconnect" function Apr 3, 2015
@jserv
Copy link
Contributor

jserv commented Apr 8, 2015

Please improve your descriptions. Don't ask question here. Instead, you should highlight the enhancements.

@Yi-Tseng
Copy link
Contributor Author

Yi-Tseng commented Apr 9, 2015

Hi @jserv
我用中文描述可能會比較清楚一點，主要的疑問是：按下 reconnect 按鈕時感覺上應該會是在原本的tab進行重新連線的動作，而不是開啟新的 tab 去連線。

另外，我這邊好像不能幫這一個 issue 標註 label。

@jserv
Copy link
Contributor

jserv commented Apr 9, 2015

@TakeshiTseng, 標題的 [Question] 令人誤解，以為這是討論區，所以你應該把按下 Reconnect 按鈕發生非預期的連線疑慮，用簡單的文字更新於標題，內文若能清楚描述 reproduce/expect 更好。

@Yi-Tseng Yi-Tseng changed the title [Question] About "reconnect" function About "reconnect" function Apr 9, 2015
@Yi-Tseng Yi-Tseng changed the title About "reconnect" function reconnect 按鈕並未將原 tab 中的連線重設 Apr 9, 2015
@noguchi167 noguchi167 mentioned this issue May 17, 2015
Closed
@NCTULouis NCTULouis mentioned this issue May 30, 2016
Closed
NCTULouis added a commit to NCTULouis/pcmanx that referenced this issue Jun 7, 2016
@NCTULouis
Instead of creating a new tab, use current connection to do reconnection
a2b41fd 
When click the reconnect button,
the previous version will create a new tab(a new connection) to do reconnection.

Instead of doing this, we use the current connection(current tab) to do reconnection.

Fix issue pcman-bbs#33
NCTULouis added a commit to NCTULouis/pcmanx that referenced this issue Jun 13, 2016
@NCTULouis
Instead of creating a new tab, use current connection to do reconnection
a49bead 
When click the reconnect button,
the previous version will create a new tab(a new connection) to do reconnection.

Instead of doing this, we use the current connection(current tab) to do reconnection.

Fix issue pcman-bbs#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jserv @kidwm @Yi-Tseng