Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

before_filter is deprecated and will be removed in Rails 5.1 #206

Open
tom-lord opened this issue Dec 19, 2016 · 2 comments
Open

before_filter is deprecated and will be removed in Rails 5.1 #206

tom-lord opened this issue Dec 19, 2016 · 2 comments

Comments

@tom-lord
Copy link

tom-lord commented Dec 19, 2016

Using the latest version of this gem (v0.9.2), and the latest Rails (v5.0.0.1), I get the following deprecation warning:

DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead.

There are only two instances of before_filter in this gem, so it should be a trivial code change.

However, also note this pull request last year, which reverted use of before_action to before_filter in order to maintain Rails 3 compatibility. According to this gem's README, it supports Rails 3.2 onwards - so annoyingly, we would need to wrap these before_action/filter declarations in if statements in order to maintain the compatibility - much like this similar PR did.

...Or, you could just drop support for Rails 3.x, seeing as it has been officially unsupported since June 2016?

The release of Rails 5.0 will mean that bug fixes will only apply to 5.0.x, regular security issues to 5.0.x and 4.2.x, and severe security issues also to 5.0.x and 4.2.x (but when 5.1 drops, to 5.1.x, 5.0.x, and 4.2.x.) This means 4.1.x and below will essentially be unsupported!

@tgodniak
Copy link

tgodniak commented Mar 16, 2017

I had the same problem and upgrading gem to latest version fix it.

gem 'devise_security_extension', git: 'https://github.com/phatworx/devise_security_extension.git', branch: 'master'

@inveterateliterate
Copy link

Are there plans to publish the latest version on master to rubygems?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants