Support commitMatcher
for app kinds other than K8sApp
#4966
Labels
kind/enhancement
New feature or request
commitMatcher
for app kinds other than K8sApp
#4966
What would you like to be added:
Support
commitMatcher
for CloudRunApp, TerraformApp, ECSApp, and LambdaApp.Why is this needed:
Currently,
commitMatcher
is only supported for K8sApp as below:K8sApp:
pipecd/pkg/app/piped/planner/kubernetes/kubernetes.go
Lines 166 to 196 in 8129078
ECSApp: does not have such logic. (CloudRun, Lambda, Terraform too)
https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/planner/ecs/ecs.go
[IMO] Such logic should be placed in the common planner.go, not platform-specific files.
The text was updated successfully, but these errors were encountered: