Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert controlled vocabulary classes to Eloquent models #10292

Open
asmecher opened this issue Aug 8, 2024 · 0 comments
Open

Convert controlled vocabulary classes to Eloquent models #10292

asmecher opened this issue Aug 8, 2024 · 0 comments
Assignees
@touhidurabir
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5.0 LTS

Comments

@asmecher
Copy link
Member

asmecher commented Aug 8, 2024 •
edited by touhidurabir
Loading

There are several classes that use the old DAO storage model to handle controlled vocabularies and related code:

  • controlled_vocab_entries and controlled_vocab_entry_settings (these will require a trait for settings tables, which @Vitaliy-1 is working on)
  • controlled_vocabs
  • user_interests

In preparation for extensions to the controlled vocabulary toolset in support of vocabulary plugins that implement specific vocabs (e.g. LCSH etc), the storage model for these tables should be migrated to Eloquent.

PRs (Draft WIP)
pkp-lib --> #10324
ojs --> pkp/ojs#4403
citationStyleLanguage --> pkp/citationStyleLanguage#127
jatsTemplate --> pkp/jatsTemplate#54
oaiJats --> pkp/oaiJats#51
@asmecher asmecher added this to the 3.5.0 LTS milestone Aug 8, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 16, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
e9c27fc
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
9375230
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
852c673
This was referenced Aug 16, 2024
Draft
Draft
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 16, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
d1e3e38
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
85bf407
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
a9d82cd
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
ae25aff
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 19, 2024
@touhidurabir
pkp#10292 WIP: Controlled Vocab DAO to Eloquent Model
a581dc9
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 WIP: Controlled Vocab DAO to Eloquent Model
5db03d3
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
09dbd87
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 19, 2024
@touhidurabir
pkp#10292 typo fixed
12072a7
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
2055e6d
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 proper model import for native xml
5cefa04
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
20fefd2
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
dd868ac
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 WIP: Controlled Vocab DAO to Eloquent Model
8b5d705
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 typo fixed
15f9263
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 proper model import for native xml
4845517
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
ff4e8f7
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
80cd267
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
22f3d1c
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 WIP: Controlled Vocab DAO to Eloquent Model
a8b8438
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 added user_interests primary key migration
c40165b
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 fixed user_interests primary key migration path
46d784e
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 fixing unit tests
1463f2d
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
c517c8b
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 26, 2024
@touhidurabir
pkp#10292 removed extended vocab classes
35ed0cb
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 removed extended vocab classes
30ddec5
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
8e762e8
touhidurabir added a commit to touhidurabir/pkp-citationStyleLanguage that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 removed extended vocab classes
093a0b5
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
91c2320
touhidurabir added a commit to touhidurabir/pkp-jatsTemplate that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 removed extended vocab classes
76c807f
touhidurabir added a commit to touhidurabir/pkp-oaiJats that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 removed extended vocab classes
9156ae1
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 26, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
5ec5ebb
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 26, 2024
@touhidurabir
pkp#10292 WIP: Controlled Vocab DAO to Eloquent Model
7cff638
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 26, 2024
@touhidurabir
pkp#10292 typo fixed
fb58eea
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 26, 2024
@touhidurabir
pkp#10292 proper model import for native xml
d6de5c0
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 26, 2024
@touhidurabir
pkp#10292 fixing unit tests
9e651ae
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 26, 2024
@touhidurabir
pkp#10292 Refactored user interest to model and repository
1e4594e
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 26, 2024
@touhidurabir
pkp#10292 removed extended vocab classes
4c2b857
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
2e4a96b
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
68b6524
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
a70690f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 WIP: Controlled Vocab DAO to Eloquent Model
6c14728
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 added user_interests primary key migration
61dfa32
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 fixed user_interests primary key migration path
cd7124d
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
c9fd95b
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
dc7c14a
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 removed user_interests table primary key migration …
db775f2 
…as already exist
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 Refactored user interest to model and repository
8f60227
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 removed extended vocab classes
1b735f1
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 26, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
9aad717
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 27, 2024
@touhidurabir
pkp#10292 fixing issue with vocab storing and some doc blocks added
3faff33
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 27, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
d121ad7
@touhidurabir touhidurabir added Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
2 participants
@asmecher @touhidurabir