Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n mechanism discards translations when msgid is changed #6159

Open
ichim-david opened this issue Jul 9, 2024 · 0 comments
Open

i18n mechanism discards translations when msgid is changed #6159

ichim-david opened this issue Jul 9, 2024 · 0 comments

Comments

@ichim-david
Copy link
Sponsor Member

ichim-david commented Jul 9, 2024

In #6109 we had a typo in the default message and msgId since we usually set it to the same value.
https://github.com/plone/volto/pull/6109/files#diff-08caa52065300f9f9f50990bdc26ff5628638fe5a7bd0337a187a4c7d739c9a4L159

Because of this when pnpm i18n runs and the msgid changes, it discards any translation added for that msgid as seen in this screenshot
i18n-translations

I had to add commit 1d501fd
in order to manually insert the values back so that we wouldn't lose these translations.

I don't know if we can make the engine smarter, or if we could use another strategy for msgid to be different from the default message making it perhaps less brittle to the actual message, leaving this issue open to discussion if we can do anything to improve this workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant