Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Line> type definition does not include <Container> properties #2632

Open
rollie42 opened this issue Aug 12, 2024 · 0 comments
Open

<Line> type definition does not include <Container> properties #2632

rollie42 opened this issue Aug 12, 2024 · 0 comments

Comments

@rollie42
Copy link

rollie42 commented Aug 12, 2024

In 0.87, renderWrapper shows as a TS error:

return <Line data={data}
        height={300}
        width={800}
        colors={["red"]}
        layers={[ "axes", "lines", "markers", "legends"]}
        axisLeft={{
          legend: "Points Scored",
          legendPosition: "middle",
          legendOffset: -40
        }}
        margin={{ top: 50, right: 50, bottom: 50, left: 50 }}
        // @ts-expect-error missing def?
        renderWrapper={false}
    />

It's one of the properties of Container added via withContainer when exporting from Line.js. Probably other components have the same problem. It looks like it could be fixed by adding a new ContainerProps type with just renderWrapper: boolean to type exports that currently include MotionProps, which is the current way other props on the Container are being exposed (ex).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant