Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced Vault Operation? #943

Closed
lautarodragan opened this issue May 7, 2019 · 1 comment
Closed

Forced Vault Operation? #943

lautarodragan opened this issue May 7, 2019 · 1 comment

Comments

@lautarodragan
Copy link
Member

Currently, Frost is running a mountAuthTune operation on Vault every time it starts.

frost-api/src/app.ts

Lines 31 to 38 in 82eb368

if (!configuration.skipVault)
try {
Vault.config(configurationVault)
if (!configurationVault.token) await initVault()
await Vault.mountAuthTune()
} catch (e) {
logger.error(e, 'Error with Vault')
}

This happens even if a Vault token is provided.

export async function mountAuthTune() {
await this.vault.mounts()
return this.vault.mount({
mount_point: 'auth/token/tune',
type: 'auth',
description: 'auth tune',
default_lease_ttl: 720,
max_lease_ttl: 4611686018, // ~146 years
force_no_cache: false,
})
}

This is running a POST /sys/mounts/auth/token/tune.

More research is needed here, but we:

  • want to remove any vault initialization or configuration code from Frost,
  • should check whether this code is really needed and
  • should make sure our docker images are doing this and do not depend on the code.

At the very least we should be able to move it out of app and into initVault.

@lautarodragan
Copy link
Member Author

Superseded by #988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant