Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add a standardised encoding scheme for the SM(S)T and its proofs #22

Closed
6 tasks
h5law opened this issue Sep 4, 2023 · 1 comment
Closed
6 tasks
Assignees
Labels
enhancement New feature or request

Comments

@h5law
Copy link
Collaborator

h5law commented Sep 4, 2023

Objective

This issue tracks the addition of a standard encoding scheme to serialise the SM(S)T itself and its proofs.

Origin Document

Encoding proofs is tracked in PR #21 however a more standardised approach to encoding not only the proofs but also the tree itself should be undertaken.

Goals

  • Decide upon an encoding scheme (gob, json, protobuf, borsh)
  • Implement the relevant helpers, functions and data types required to serialise and deserialise the tree and proofs deterministically

Deliverable

  • Deterministic serialisation and deserialisation of proofs, and entire trees

Non-goals / Non-deliverables

  • Change any underlying logic in the SM(S)T and proof mechanics

General issue deliverables

  • Update any relevant README(s)
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • Task specific tests or benchmarks: go test ...
  • New tests or benchmarks: go test ...
  • All tests: go test -v

Creator: @h5law
Co-Owners: @h5law

@h5law
Copy link
Collaborator Author

h5law commented Jan 10, 2024

I think the encoding should focus on the proofs themselves. Not the entire SM(S)T. Closing this issue for now as we have basic proof serialisation via gob.

@h5law h5law closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant