Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First row below the header in Primer::Beta::Box has rounded corners #2684

Open
HDinger opened this issue Mar 11, 2024 · 3 comments
Open

First row below the header in Primer::Beta::Box has rounded corners #2684

HDinger opened this issue Mar 11, 2024 · 3 comments
Labels
bug Something isn't working rails

Comments

@HDinger
Copy link
Contributor

HDinger commented Mar 11, 2024

Version

0.19.0

Steps to reproduce

e.g.

render(Primer::Beta::BorderBox.new) do |component|
  component.with_header { "Header" }
  component.with_body { "Body" }
  component.with_row { "Row one" }
  component.with_row { "Row two" }
end

Actual behavior

  • The row has additional round corners at the top which looks weird because the header (or the body) is directly at the top:
Bildschirmfoto 2024-03-11 um 14 08 54 Bildschirmfoto 2024-03-11 um 14 09 18
  • This becomes especially obvious in the high contrast themes
  • The same issue appears when there is a body used but no footer:
Bildschirmfoto 2024-03-12 um 08 57 25

Expected behavior

  • There should be no rounded corners if a header (or a body) is defined.
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label Sep 8, 2024
@HDinger
Copy link
Contributor Author

HDinger commented Sep 9, 2024

Please leave it open.

@github-actions github-actions bot removed the Stale Automatically marked as stale. label Sep 9, 2024
@lesliecdubs lesliecdubs added the bug Something isn't working label Sep 13, 2024
@jonrohan
Copy link
Member

Sorry this has been hanging around a while. We've been discussing the best approach here. The feeling is that a css only fix might lead to other regressions, but we're talking about the idea of adding supplemental classes in ruby to signify last/first elements in the row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rails
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants