Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog spacings between content and header in Rails #3008

Open
marcalcobe opened this issue Aug 15, 2024 · 2 comments · May be fixed by #3043
Open

Dialog spacings between content and header in Rails #3008

marcalcobe opened this issue Aug 15, 2024 · 2 comments · May be fixed by #3043
Labels
question Further information is requested rails

Comments

@marcalcobe
Copy link

Pain point

  • When using a Dialog with Rails the content of the dialog and the header have no separation between them.
  • This is more evident when you use a header with divider as the content goes just bellow the divider (see screenshot bellow).
  • If the content is just a text then there is no padding or margin added to separate it from the header.
  • We noticed that this isn't a problem in the React version, where the content has always a padding around it (see screenshot bellow).

Screenshots

- Rails with divider:
Screenshot 2024-08-15 at 12 19 12

- Rails without divider:
Screenshot 2024-08-15 at 12 19 21

- React:
Screenshot 2024-08-15 at 12 19 31

I know that this might be a design decision, so I'd would like to understand why is it different in React vs Rails.

Copy link
Contributor

Uh oh! @marcalcobe, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@lesliecdubs lesliecdubs added the question Further information is requested label Aug 15, 2024
@lesliecdubs
Copy link
Member

👋 Hi, thanks for reporting this! I don't believe this was an intentional design decision.

The Dialog component is still in Alpha. This kind of improvement would be something we could take a look at rectifying if we invest in bringing Dialog to Beta. In the meantime, we would recommend manually adding some padding to the dialog contents.

@HDinger HDinger linked a pull request Aug 30, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested rails
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants