Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonJS testing cycle uses stale data #138

Open
dibenede opened this issue Oct 5, 2022 · 1 comment
Open

CommonJS testing cycle uses stale data #138

dibenede opened this issue Oct 5, 2022 · 1 comment
Assignees
@dibenede
Labels
bug Something isn't working triaged Issue has been triaged

Comments

@dibenede
Copy link
Contributor

dibenede commented Oct 5, 2022

In the process of generating a PR, I noticed that the GitHub test runners caught issues in commonjs/{import_test.js,strict_test.js} that weren't triggered by my local gulp test_commonjs runs. Closure tests did not seem to be impacted.

E.g. https://github.com/protocolbuffers/protobuf-javascript/actions/runs/3187010981/jobs/5198166279
@dibenede dibenede added the bug Something isn't working label Oct 5, 2022
@dibenede
Copy link
Contributor Author

Added "clean" commands in #146 to mitigate this a bit.

@dibenede dibenede added the triaged Issue has been triaged label Oct 25, 2022
@dibenede dibenede self-assigned this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibenede dibenede

Labels
bug Something isn't working triaged Issue has been triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dibenede