Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Issues Identified in runner at validator/client/runner.go #14253

Open
yhassanzadeh13 opened this issue Jul 21, 2024 · 1 comment
Open
Labels
Priority: Low Low priority item

Comments

@yhassanzadeh13
Copy link

💎 Issue

Background

I noticed a few minor issues with runner at validator/client/runner.go:

  1. slotCtx is not cancelled upon return, which may cause a context leakage.
  2. span is not closed on all execution paths, e.g., here.
  3. It seems that slotCtx can be better scoped, e.g., in this invocation, slotCtx seems a more appropriate option than the general ctx due to its scope.

I can proceed with a PR if we have a shared agreement on the enhancements related to these minor issues.

Description

@james-prysm james-prysm added the Priority: Low Low priority item label Jul 23, 2024
@james-prysm
Copy link
Contributor

I'd say we should leave this as a lower priority. we are looking at rewriting much of runner.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Low priority item
Projects
None yet
Development

No branches or pull requests

2 participants