Add support for PEP 730 iOS packaging #12962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The vendoring CI check is failing because of the applied patch, which isn't surprising. The developer guide suggests there might be a way to specifically include patches; but if so, it's not clear how to set this up. Alternatively, I guess we have to wait until pypa/packaging#832 (or a variant of it) is merged, then update the vendor file. |
uranusjr
approved these changes
Sep 11, 2024
freakboy3742
commented
Sep 12, 2024
| @@ -8,7 +8,7 @@ def test_filenotfound_error_message(script: Any) -> None: | |||
| # Test the error message returned when using a bad 'file:' URL. | |||
| # make pip to fail and get an error message | |||
| # by running "pip install -r file:nonexistent_file" | |||
| proc = script.pip("install", "-r", "file:unexistent_file", expect_error=True) | |||
| proc = script.pip("install", "-r", "file:///unexistent_file", expect_error=True) | |||
There was a problem hiding this comment.
This change has been submitted separately as #12964; it's included here to prove CI isn't failing because of this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for PEP 730 iOS wheels. It will match any iOS wheel with the same multiarch configuration (i.e,
arm64_iphoneos); it also matches any iOS minor version from iOS 12.0 (the first iOS version known to support all of CPython) to the version requested by the--platformargument.This includes a patch to the vendored
packaginglibrary; this patch has been submitted upstream as pypa/packaging#832.Fixes #12961.