Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonlinear storage constant units #8

Open
snorfalorpagus opened this issue Sep 16, 2016 · 2 comments
Open

Nonlinear storage constant units #8

snorfalorpagus opened this issue Sep 16, 2016 · 2 comments

Comments

@snorfalorpagus
Copy link
Member

The nonlinear storage constant (Cq) has units "volume.time" (i.e. L^3.T).

The current docstring for this is incorrect: https://github.com/jetuk/pycatchmod/blob/d43438d9f8b9013c8241a8eebce81ca6ac0cd2a9/pycatchmod/_catchmod.pyx#L150

The excel version of catchmod stores this parameter with units cumec.days^2/km^2, i.e. L^3.T^-1.T^2.L^-2, which cancels to L.T. Before calculation, this is multiplied by area (L^2) to give the required units. In addition, the value is multiplied by 86.4, which converts m3/s to Ml/d.

We need to decide how to handle this.

@snorfalorpagus
Copy link
Member Author

This is a little tricky to fix because of the way NonLinearStore is independent of SubCatchment. It's not clear where the best place to do the conversion is, especially if it needs to be robust to subsequent changes to both the constant, and the area.

@jetuk
Copy link
Member

jetuk commented Sep 20, 2016

I think this is because the area is multiplied through between linear and non-linear storage components. Perhaps that multiplication can be done last, and then Cq doesn't need to be multiplied through by area.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants